Merge updates for Japanese translation.

DOsinga / deep_learning_cookbook

Deep Learning Cookbox

Apache License 2.0

689 stars 338 forks source link

Merge updates for Japanese translation. #38

Closed ohtaman closed 9 months ago

ohtaman commented 5 years ago

Sorry, this PR is sent by mistake

DOsinga commented 5 years ago

Sorry about that, inadvertently closed this.

ohtaman commented 5 years ago

Sorry, this PR my mistake and so I closed this by myself.

In fact, now I'm trying to update whole samples for the Japanese version of your book. Is there any good way to collaborate with this original repository? Now, we are working to

support TensorFlow 2.0.
remove/update some redundant codes.
maybe remove some code which uses outdated libraries or methods.
- and it may be possible to add new more modern codes.
translate markdowns to Japanese.

I believe some of the above (maybe except the last one) are worthful also for this original repository.

DOsinga commented 5 years ago

Yes, that sounds great!

Why don't you send me a PR with the English only changes and then we just create a separate repository for the Japanese version? I don't think notebooks support dual language yet :)

I'm at douwe.osinga@gmail.com if you want to email directly. Happy to chat on whatever medium.

DOsinga commented 5 years ago

Hey!

How is this going? I pushed some updates and fixes partly based on your work. Happy to incorporate anything else that is reasonable. Let me know!

Douwe

ohtaman commented 5 years ago

Hi! Now we are working on translation towards publishing, hopefully in September.

Since it is diffucult to manage *.ipynb on git (difficult to see diff, difficult to resolve conflicts, ... ), I want to keep PRs simple. Thus I'm thinking to close this PR and create other branches and PRs per .ipynb file. Is it OK?

ohtaman commented 5 years ago

FYI: https://app.reviewnb.com/ maybe help to treat ipynb on github. I use this tool for tensorflow/docs translation.