search

DOsinga / deep_learning_cookbook

Deep Learning Cookbox
Apache License 2.0
686 stars 335 forks source link

Update ch03 #58

Closed ohtaman closed 7 months ago

ohtaman commented 5 years ago
  1. Sort import statements
  2. Change keras to tensorflow.keras
    • Currentry, original Keras, not tf.keras, is not suitable for TensorFlow 2.0. So we want to use tf.keras everywhere.
  3. Add gzip module and remove some code to call zcat
    • I prefer standard module to external commands. But this change may not be necessary.
  4. Add note about a error caused by cache.
    • I'm not English native. Please point out if the grammar is wrong
ohtaman commented 5 years ago

TensorFlow 2.0 and 1.0 are not compatible, so it may be better to have another branch instead of master. @DOsinga How do you think?

DOsinga commented 5 years ago

It would be a good idea to move to 2.0, but yeah, it would need careful testing. It seems you are better at that then I am, so sure, why not. But maybe like you suggest we can put this together in a feature branch that we work on together?

DOsinga commented 5 years ago

Any thoughts on how to best progress on this?

MarcusFra commented 3 years ago

Dear @DOsinga, are you still planning to update to TensorFlow 2.x? Or do you know any fork for which it was done yet? There are some readers (of the german translation) who ask for.