DP-3T / dp3t-sdk-android

The DP3T-SDK for Android
Mozilla Public License 2.0
242 stars 94 forks source link

Feature/increas number of uploaded keys #192

Closed simonroesch closed 4 years ago

simonroesch commented 4 years ago

This PR prepares the SDK for same day TEK release. There are two changes: 1) we always upload 30 keys, to be sure that all available keys fit into the upload. With same day TEK release multiple TEKs are generated for the same day which theoretically can lead to more than 14 keys during the last 14 days. 2) the next day TEK upload that was used to upload the current days TEK is only done if the current day TEK is not already released when asking for the TEKs. If we do not need to do a next day TEK upload, we schedule a fake next day upload to make sure we always have the same network pattern. Once most devices will have same day TEK release enabled, we will be able to completely remove the next day upload for real and fake uploads.

Closes #194

simonroesch commented 4 years ago

Closes #194

ineiti commented 4 years ago

Closes #194

I think it needs to go in the first comment of the PR...

simonroesch commented 4 years ago

Closes #194

I think it needs to go in the first comment of the PR...

Github magic ;-)

ineiti commented 4 years ago

Github magic ;-)

TIL:

From https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

You can also use closing keywords in a commit message. The issue will be closed when you merge the commit into the default branch, but the pull request that contains the commit will not be listed as a linked pull request.

So if I understand correctly, putting the issue in a comment will close the issue, but not add a link from the issue to the PR. This happens only when you put it in the PR comment. Does that sound correct?

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more here