The test-helper method insertNKeysPerDayInIntervalWithDebugFlag is difficult to understand. Together with @martinalig we propose the following signature:
/**
* Creates keysPerDay for every day: lastDay, lastDay-1, ..., lastDay - daysBack + 1
*
* @param lastDay of the created keys
* @param daysBack of the key creation, counted including the lastDay
* @param keysPerDay that will be created for every day
* @param receivedAt as sent to the DB
* @param debug generates more output in `upsertExposees`
*/
private void insertNKeysPerDayInIntervalWithDebugFlag(UTCInstant lastDay, int daysBack, int keysPerDay,
UTCInstant receivedAt, boolean debug){}
Also adapt all dependant tests:
testDebugController
zipContainsFiles - also fix the now.MinusDays(12) -> now.MinusHours(12) and use of UTCInstant in bucketAfterSecondRelease
The test-helper method
insertNKeysPerDayInIntervalWithDebugFlagis difficult to understand. Together with @martinalig we propose the following signature:Also adapt all dependant tests:
testDebugControllerzipContainsFiles- also fix thenow.MinusDays(12)->now.MinusHours(12)and use ofUTCInstantinbucketAfterSecondReleasetestEtag