213 is getting ready for code review. Here the findings so far:
[x] GaenControllerTestNotThreadSafe.java - it reproduces some of the errors fixed in #220 - we need to make sure these errors are not inserted again. In the best case, reverting to the tests that are now in develop should make it pass. -> @ineiti verify that the test zipContainsFiles is in GaenControllerTest.java and working correctly.
[x] GaenControllerTest - I'm not sure what is the correct User-agent to use - but if it's the Android one, that should go into a class variable.
[x] InsertManager - needs some class documentation - @wouterl writes: Nice! Maybe just write one or two lines of documentation here. Something that says "only accept keys that look valid". And maybe a ref to the modifiers if enabled. That's only the configuration - discuss in #235 whether it's necessary or not.
[x] Code review - @wouterl asked for some days for an internal review of what is happening here.
Merging
Now #213 depends on #230, so:
first REBASE #230 into develop
then, once #213 is ready, REBASE #213 into develop
In fact @wouterl wrote For now, it should be ok to merge this. on slack - so we should be go for this, once 230 is rebased on develop, and this is rebased on develop.
Work to do
213 is getting ready for code review. Here the findings so far:
GaenControllerTestNotThreadSafe.java
- it reproduces some of the errors fixed in #220 - we need to make sure these errors are not inserted again. In the best case, reverting to the tests that are now indevelop
should make it pass. -> @ineiti verify that the testzipContainsFiles
is inGaenControllerTest.java
and working correctly.GaenControllerTest
- I'm not sure what is the correct User-agent to use - but if it's the Android one, that should go into a class variable.InsertManager
- needs some class documentation - @wouterl writes: Nice! Maybe just write one or two lines of documentation here. Something that says "only accept keys that look valid". And maybe a ref to the modifiers if enabled. That's only the configuration - discuss in #235 whether it's necessary or not.Merging
Now #213 depends on #230, so:
first REBASE #230 into develop then, once #213 is ready, REBASE #213 into develop