Tag v2.0.0 doesn't pass tests

DP-3T / dp3t-sdk-backend

The backend implementation for DP3T

Mozilla Public License 2.0

199 stars 87 forks source link

Tag v2.0.0 doesn't pass tests #271

Closed iCesofT closed 3 years ago

iCesofT commented 4 years ago

Hi,

If I download the .tar.gz from https://github.com/DP-3T/dp3t-sdk-backend/releases/tag/v2.0.0:

I have to init git because the plugin git-commit-id-maven-plugin. You should add:
```
<failOnNoGitDirectory>false</failOnNoGitDirectory>
```

If I try to package (make package o mvn clean package), I get these results:

[ERROR] Failures:
[ERROR]   GaenDataServiceTest.upsert:71 expected: <2> but was: <0>
[ERROR]   PostgresGaenDataServiceTest.upsert:186 expected:<1> but was:<0>

iCesofT commented 4 years ago

Maybe depends on time execution those tests work? I run again right now and it worked :?

ineiti commented 4 years ago

That's very interesting. We had some tests that didn't run because it used the local time to calculate some boundaries, and it failed either in the afternoon, or close to midnight. Might be something similar here. I'll have a look at it later this afternoon.

martinalig commented 3 years ago

I will close this issue for now, as v2.1.0 and v2.2.0 have been released.