search

DP-3T / dp3t-sdk-ios

The DP3T-SDK for iOS
Mozilla Public License 2.0
151 stars 61 forks source link

Remove 'Bearer' prefix from auth token. #215

Closed lauriesk closed 4 years ago

lauriesk commented 4 years ago

The DP3T iOS SDK modified the auth key of HTTPAuthorizationBearer auth method with a 'Bearer' prefix. This was not in sync with Android SDK implementation. This PR removes this prefix.

Changelog was modified, because this change may potentially break existing projects if backend is configured to expect this prefix.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stmitt commented 4 years ago

@lauriesk Thank you very much for your input. We have addressed this in https://github.com/DP-3T/dp3t-sdk-ios/pull/227 and introduced an ExposeeAuthMethod which gives the app more control over the HTTP headers.