search

DP-3T / reference_implementation

Apache License 2.0
127 stars 44 forks source link

Cleanups and various minor improvements #8

Closed jherland closed 4 years ago

jherland commented 4 years ago

Here are various things I found while taking an initial look at this code. It's mostly centered around the example_run script, and trying to make things safer and more readable. Feel free to take as many of these commits as you see fit.

wouterl commented 4 years ago

Thanks @jherland for the thorough list of comments. Much appreciated. We did a massive rewrite and restructure. I think we managed to incorporate almost all of your suggestions. Thanks for pushing us to write nice Python code.

I'm going to close this for now, but please do have a look at the new version. Feedback welcome.

jherland commented 4 years ago

Ok. Resubmitted a new pull request #17 with some of the stuff left in my branch, as well as some low-hanging fruits.