search

DPDBeNeLux / magento-DPD_Shipping

Let op: er zijn nieuwe DPD plugins (BETA versie) beschikbaar met belangrijke nieuwe functionaliteiten. De oude plugins zullen na Brexit niet meer goed functioneren, download daarom de nieuwe versie op Github/DPDconnect.
11 stars 10 forks source link

Shipping method identifiers not matching #54

Open lkreher opened 8 years ago

lkreher commented 8 years ago

When listing available shipping modules in the backend via toOptionsArray, the shipping method "DPD Home Delivery" is identified as 'dpdclassic_classic', but when placing an order the same shipping method is identified as 'dpdclassic_dpdclassic'. This breaks compatibility with other modules that provide further options for specific shipping methods.

A quick fix would be: Replace

    public function getAllowedMethods()
    {
        return array('classic' => $this->getConfigData('name'));
    }

with 

    public function getAllowedMethods()
    {
        return array($this->_code => $this->getConfigData('name'));
    }

in Model/Carrier/Dpdclassic.php, but I'm not 100% certain this works without causing other issues.

mvgucht commented 8 years ago

Hey lkreher,

thanks for your feedback. that looks like a typo. I can not find any reference to classic_dpdclassic.

how are your preliminary tests going?

lkreher commented 8 years ago

I'm talking about the backend function "toOptionsArray" of the full set of shipping methods, which creates a list of all available shipping methods and allows the user to select multiple shipping methods, similar to payment methods, shipping countries etc. This is not specific to this module, but a base function of magento.

But in the list created by that function the shipping methods receive an identification name apparently constructed by the carrier code ('dpdclassic' in this case) and the allowed methods provided by "getAllowedMethods()". So for each method in the return array of that function it will create a list item with 'dpdclassic_'.$arraykey as identifier, and right now the key is simply 'classic'.

My proposed fix changes the array key to 'dpdclassic', and this way the identifiers match up. We are still in the process of setting up everything, so I am still not sure this fix does not break some other functionality, but we have not found any problems yet.