search

DPDBeNeLux / magento2-shipping

Let op: er zijn nieuwe DPD plugins (BETA versie) beschikbaar met belangrijke nieuwe functionaliteiten. De oude plugins zullen na Brexit niet meer goed functioneren, download daarom de nieuwe versie op Github/DPDconnect.
GNU General Public License v3.0
12 stars 15 forks source link

`condition_name` field not long enough #34

Open crossgate9 opened 5 years ago

crossgate9 commented 5 years ago

Dear,

We are using the 1.2.0 version of the extension. With the DPD Classic method, it is "package_value_with_discount" in the Condition Dropdown. But in the database, the length of condition_name field for table dpd_shipping_tablerate is only 20 characters long, which will cut the condition into "package_value_with_d".

Please kindly update the extension.

Best Regards, Allen

SolsWebdesign commented 4 years ago

Very bad, took me ages to find out why dpd shipping table rates do not work for price vs condition! I found indeed that it needs a method named "package_value_with_discount" and this is cut short to package_value_with_d by the database table! Very bad indeed. I was trying to use dpd predict but the same happens for dpd classic. Please fix this because this is not good!

SolsWebdesign commented 4 years ago

added a pull request