search

DPDBeNeLux / magento2-shipping

Let op: er zijn nieuwe DPD plugins (BETA versie) beschikbaar met belangrijke nieuwe functionaliteiten. De oude plugins zullen na Brexit niet meer goed functioneren, download daarom de nieuwe versie op Github/DPDconnect.
GNU General Public License v3.0
12 stars 15 forks source link

Set proper requirement versions #54

Open JKetelaar opened 4 years ago

JKetelaar commented 4 years ago

This way you avoid having to update your composer.json every single release of your dependencies, without really being in danger of having incompatible versions.

The PHP version is simply the recommended version for every Magento 2 site.

hostep commented 4 years ago

Magento 2.3.4 is compatible with up to PHP 7.3.x, just saying.

Honestly, you could test the code with something like https://github.com/PHPCompatibility/PHPCompatibility/ and then declare all the PHP versions which the tool is not complaining about. In this case you can probably already include PHP 7.4 as well even if no Magento version is out there which officially supports it yet.

JKetelaar commented 4 years ago

There needs to be some backwards compatibility

JKetelaar commented 4 years ago

And this change allows php 7.0+ with some restrictions on php 7.0 minor versions

hostep commented 4 years ago

Ah sorry, I didn't notice you used ^7.1.0, I though it was ~7.1.0. My bad!

I don't like ^7.1.0 or >=7.0.13 though, because you can't know if the code will be 100% compatible with PHP 7.5 (which probably will not be released, but who knows).

JKetelaar commented 4 years ago

If you don’t do this, then the developers need to update this on each release. And knowing the magento community (including this extension apparently), this doesn’t happen as often. So I’d rather be safe on that side, than wait for developers to update the compose.json, even if the code still might work.

I do agree with you though if the extension was daily/weekly maintained.

JKetelaar commented 4 years ago

@dpdplugin