search

DPGAlliance / publicgoods-scripts

Scripts to generate static site from WordPress
http://digitalpublicgoods.net
MIT License
4 stars 6 forks source link

Updated project name url to point to DPG website #132

Closed nathanfletcher closed 2 years ago

nathanfletcher commented 2 years ago

This PR fixes #131 and reveals a potential bug in the generate_dpgs.js script. cc @lacabra

Upon testing locally, I realized that the individual pages were not being properly generated because the template used for the pages did not have the word Placeholder. this Placeholder keyword is what the code looks for to replace the content of the template.

Unless I am missing something, I would suggest that the template be fixed in the publicgoods-website repo by adding the Placeholder keyword before pushing this PR.

I have been wondering why this has not shown up earlier (again, unless I'm missing something)

helpNeeded

lacabra commented 2 years ago

@nathanfletcher The reason this works is because the <p>Placeholder</p> is indeed found in the internal Heroku site. Once it gets processed and published to the template you linked above, the Placeholder has already been replaced.