search

DPGAlliance / publicgoods-scripts

Scripts to generate static site from WordPress
http://digitalpublicgoods.net
MIT License
4 stars 6 forks source link

fix(registry): fixes filtering registry entries by SDG #206

Closed sfishel18 closed 1 year ago

sfishel18 commented 1 year ago
sfishel18 commented 1 year ago

👋 hello! i love the project and the mission behind it. i noticed when browsing the registry that the checkboxes to filter by SDG don't always work correctly, so this PR is a small fix to get that working. i also hit a few snags with the setup instructions so i updated them to what worked for me. (edit: moved to a separate PR)

gazdagergo commented 1 year ago

👋 hello! i love the project and the mission behind it. i noticed when browsing the registry that the checkboxes to filter by SDG don't always work correctly, so this PR is a small fix to get that working. i also hit a few snags with the setup instructions so i updated them to what worked for me.

Thanks SImon, and welcome to the contributor hub! Let me check your changes and I get back to you soon! I'm super excited to have you on board.

law909 commented 1 year ago
  • updates logic to compute SDG filter key based on clicked checkbox
  • updates project setup instructions

Please provide two separate PRs for the two fixes.

sfishel18 commented 1 year ago
  • updates logic to compute SDG filter key based on clicked checkbox
  • updates project setup instructions

Please provide two separate PRs for the two fixes.

👍 done

law909 commented 1 year ago
  • updates logic to compute SDG filter key based on clicked checkbox
  • updates project setup instructions

Please provide two separate PRs for the two fixes.

👍 done

Thank you!

gazdagergo commented 1 year ago

Thanks Simon! 🙏 Let's wait for the required review of @nathanfletcher . We have tested it with @law909 and looks goot to us and can be merged.