DPGAlliance / publicgoods-website

Static version of the Digital Public Goods website
http://digitalpublicgoods.net
7 stars 8 forks source link

[fix] URL in the Who-We-Are section #11

Closed frju365 closed 2 years ago

frju365 commented 2 years ago

Problem: On the main website, https://digitalpublicgoods.net/who-we-are/, two links in the "Our Approach" seems dead, and built for dev.

Solution: Correct the two links.

Status: Not tested -> Minor changes. Waiting for review.


PS : Not sure it's a good contribution, but I tried :-)

frju365 commented 2 years ago

Not sure that https://digitalpublicgoods.net/who-we-are/ is the right link for the "Pathfinder Countries" infos.

lacabra commented 2 years ago

Thanks @frju365 for pointing out these incorrect links and proposing a solution. The contents for this repository are automatically regenerated periodically, so any manual changes are later discarded by subsequent commits. However, your pointing out of these broken links is very much appreciated and I have gone ahead and corrected these links at the source, and triggered a new build of the website resulting in commit 4e1551a that has those links fixed.

Thanks again!

Cc: @SarahWat

frju365 commented 2 years ago

Hey ! Well, i quite understood that commit were made automatically, but I didn't know how to suggest a change. Is there a way to do these commit in the good way.

Another queestion. I don know if it's the place to ask this question : I'm today a young dev and future engineer and I wanted to contribute to this project. I wanted to know if there are some ways to contribute to this project and if there was a project which would need more contributions than another. I saw https://github.com/lacabra/submission-digitalpublicgoods which can be interesting for me.

frju365 commented 2 years ago

Or perhaps is it better to open a dedicated issue ? @lacabra

lacabra commented 2 years ago

Hi @frju365, answering your first question, any content-related changes are handled by a WordPress instance that is managed by our comms team and is not public, so in this case, opening an issue is already great, and we can address it promptly. Code-related changes and improvements can be made in unicef/publicgoods-candidates and unicef/publicgoods-scripts.

Thanks for your interest in contributing, the submission-digitalpublicgoods repo that you mention above is indeed open for contributions, maybe lacabra/submission-digitalpublicgoods#26 or lacabra/submission-digitalpublicgoods#23 (see the progress bar implemented here (code here) for a good reference since it uses a very similar codebase). Alternatively, lacabra/submission-digitalpublicgoods#28 could also be a good first issue.

Cc: @nathanfletcher

frju365 commented 2 years ago

Thanks for you answer, I will try to contribute to the https://github.com/lacabra/submission-digitalpublicgoods repo !