Review and provide feedback

DPI-WE / command-line-interface-cli-project

0 stars 1 forks source link

Review and provide feedback #3

Open heratyian opened 3 months ago

heratyian commented 3 months ago

@DPI-WE/technical-associates

armstrca commented 2 months ago

Looks good overall to me. All the links work correctly.

Attributes for an instance variable (eg use @ with attr_accessor, attr_writer, attr_reader, and/or your own custom getters/setters)

I know it's already at the top of the doc, but it could be helpful to link "getters/setters" to whichever lesson/lesson subsection the terms are first introduced in.

aldoportillo commented 2 months ago

I liked this lesson. I made a CLI Rubber Ducky.