DPI-WE / semantic-html-and-accessibility

0 stars 1 forks source link

Please review and provide feedback #1

Open heratyian opened 5 months ago

heratyian commented 5 months ago

@DPI-WE/technical-associates

thierrychau commented 5 months ago
heratyian commented 5 months ago

is it a good place to link to external resources? Or maybe a link to the SEO lesson

I moved this lesson to the seo module and renamed it accessibility and seo.

heratyian commented 5 months ago

You don't mention

at all, and they are profusely used on the internet. Are they supposed to be the last resort, after all other structural tags you mentioned have been used? Is it bad to use them at all?

divs aren't bad, they just don't communicate anything.

heratyian commented 5 months ago

Thoughts on making HTML and accessibility ## level sections? And their sub section ###? The example can be a ## level too. I like having a clearer separation between both subjects.

Agreed. Want to make a quick PR?

heratyian commented 5 months ago

How does using id affect accessibility?

I don't think it does? 🤔

heratyian commented 5 months ago

the WCAG guidelines (perceivable, operable, understandable, and robust) do not speak much to me in this format...

Makes sense. I'll create an issue and work on some stronger examples.