DPLATA / mexdata

mex data viz project repo. everything mex-related
Apache License 2.0
3 stars 0 forks source link

add charts to LMBstats page #5

Closed DPLATA closed 1 year ago

DPLATA commented 1 year ago

each key for any object in top_25_at_bat_LMB json file should have its own individual chart in LMBStats page, for now it will only contemplate line charts. This should be a pretty straight forward task and the following steps will provide you with a detailed guideline to get it done. You should make the following changes, where appropriate:

  1. create a new issue for the state you want to add to the repo by converting task to issue (rightmost icon within the task)
  2. wait for someone to assign it to you to start working on it
  3. copy the following code snippet <CustomLineChart width={600} height={300} data={lmb_stats} name='' xAxisDataKey='player' type='monotone' gridHexColor='#ccc' legendHeight={36} lineDataKey='HR' strokeHexColor='#8884d8'/>
  4. copy the snippet below the last chart in src/pages/LMBStatsPage.js file
  5. add to dataKey="" the value of the dataKey you choose e.g. dataKey="AB"
  6. open a PR and request a review. Make sure to include the line "Fixes #number_of_your_issue" to automatically closing the issue when the PR is merged.

For the following dataKeys:

IF YOU HAVE ANY DOUBTS DON'T HESITATE ON POSTING YOUR QUESTIONS

DPLATA commented 1 year ago

avg #6

DPLATA commented 1 year ago

hr #7

DPLATA commented 1 year ago

LMB chart section replanned