DPLYR-dev / SplashScreenFlutterPackage

A small splashscreen used as intro for flutter applications easily with a lot of customizations ❤️🥳
MIT License
294 stars 123 forks source link

Null-Safety support #63

Closed kuromukira closed 3 years ago

kuromukira commented 3 years ago

Is your feature request related to a problem? Please describe. No dart null-safety support which prevents us from migrating to null-safety

Describe the solution you'd like Add dart null-safety support

Describe alternatives you've considered Copy your code and implement null-safety inside our project

Additional context NA

leynier commented 3 years ago

Any update guys? I could be make a PR with null safety support implementation.

ahmedmgh67 commented 3 years ago

Hello @kuromukira , Adding null-safety support is on our roadmap, if @leynier can make a PR first we'll merge it for sure and we would love that you contribute to the project, otherwise it's still gonna be developed in the coming 2-3 months

leynier commented 3 years ago

PR is comming 🚀 😄

Hello @kuromukira , Adding null-safety support is on our roadmap, if @leynier can make a PR first we'll merge it for sure and we would love that you contribute to the project, otherwise it's still gonna be developed in the coming 2-3 months

kuromukira commented 3 years ago

Thanks @leynier 👌🏻

@ahmedmgh67 Thanks. I'd check the issues whenever I get free time to see if I'll be able to contribute on some of them!

leynier commented 3 years ago

PR is done 🚀

ahmedmgh67 commented 3 years ago

@leynier Amazing!, I'll review it now, merge it, and publish it as a minor update

joyner-perez commented 3 years ago

Please, aprobe the @leynier PR

leynier commented 3 years ago

@ahmedmgh67 please 🙏🏻 review this PR #64, we need null safety support.