Module ID is not consistent in AMP archetype

[GoogleCodeExporter]

In module.properties there is:
module.id=${pom.artifactId}

In src/main/config/service-context.xml there is:
<property name="moduleId" value="${pom.groupId}.${pom.artifactId}" />  <!--
See module.properties -->

This lead to issue when deploying AMP:
11:29:35,927 INFO  [repo.module.ModuleServiceImpl] Found 1 module(s).
11:29:37,552 INFO  [repo.module.ModuleServiceImpl] Installing module
'myamp' version 1.0.1.
11:29:38,130 ERROR [repo.module.ModuleComponentHelper] The component
'myamp.exampleComponent' belongs to a non-existent module
'com.mycompany.myamp'.

Please also note that pom.* properties are deprecated and you should use
project.*

See attached patch.

Original issue reported on code.google.com by glaurung...@gmail.com on 3 Mar 2010 at 11:16

Attachments:

• alfresco-maven-amp-moduleId.patch

[GoogleCodeExporter]

Ok, yesterday I did my first commit on this project and this error is my fault. 
I 
must have missed the removal of ${groupId} here, bad start for me :(

I will fix this, but instead of adding groupId like you did in the patch I will 
remove it in from service-context.xml. See issue #26.

At the same time I will fix the deprecated pom.* stuff.

Thanks for spotting this.
/Erik

Original comment by bille...@gmail.com on 3 Mar 2010 at 6:54

• Changed state: Started

[GoogleCodeExporter]

This should be ok now.

/Erik

Original comment by bille...@gmail.com on 3 Mar 2010 at 7:18

• Changed state: Fixed