search

DPascalBernard / maven-alfresco-archetypes

Automatically exported from code.google.com/p/maven-alfresco-archetypes
0 stars 0 forks source link

Maven Alfresco Share: shipped share-config-custom.xml review #70

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
I was going to personalize share by modifying the share-config-custom.xml file 
shipped with the Maven archetype

I blindly added my config at the top without looking at the other settings...

My config wasn't used since down, below there was already this:

<config evaluator="string-compare" condition="DocumentLibrary" replace="true">
[...]
</config>

this was replacing my config too

So question is: is this just an example?
Why are things replaced by default?

Some setting in the share-config-custom.xml are needed, and I can see it, like 
the server setting

but I think that one is just an example

On other I'm not sure since I don't know exactly what they does...

Listing them as the appear in the file:
(sorry couldn't find a tag)
http://maven-alfresco-archetypes.googlecode.com/svn/trunk/maven-alfresco-archety
pes/maven-alfresco-share-archetype/src/main/resources/archetype-resources/src/ma
in/resources/alfresco/web-extension/share-config-custom.xml

* Server -- this is needed
* /global/ -- is this really needed? (apparently change some default about 
debug logging)
* WebFramework -- this is used in the pom.xml and can actually be useful for 
development, I think it should be commented out by default anyway
* Replication -- empty sample
* DocumentLibrary -- I think everything here is just an example, may be some 
suggestion in it but I think it should be commented out by default
* DocLibActions -- an example, not sure what it is needed, never used 
DocLibActions
* GlobalFolder -- I really don't know about this, what does it do?
* RepositoryLibrary -- this seems an example to me and should be commented out
* KerberosDisabled -- example on how to setup kerberos, should be commented out
* Remote -- this is needed since we use application.properties with environment 
to set up where our alfresco is running

Original issue reported on code.google.com by daniele....@gmail.com on 1 Mar 2012 at 12:56

GoogleCodeExporter commented 8 years ago 
Marked as enhancement

Original comment by mauri...@session.it on 3 Apr 2012 at 10:26

GoogleCodeExporter commented 8 years ago 
This opens to me a much broader discussion, i.e:

I think we need to align to Alfresco version releases, to make it absolutely 
clear which Alfresco version the archetypes have been tested with. Likewise 
every new archetype version should ship the appropriate (unpacked and added to 
layout) version of the sample-extensions-<version->.zip as released by 
Alfresco, to include new share features and be resilient to Share config 
changes.

I this could be automated and I am also in favor of leaving everything as 
.sample in the archetype generated source tree to avoid side effects like the 
ones Daniele describes.

WDYT?

Original comment by colum...@gmail.com on 8 Apr 2012 at 9:11

GoogleCodeExporter commented 8 years ago 
Hi Gabriele,

I don't know about the automation but I agree with you the 
share-config-custom.xml should ship the minimum setting to make it work.

I agree with you, everything else should be moved to an example file.

Original comment by daniele....@gmail.com on 8 Apr 2012 at 10:14

GoogleCodeExporter commented 8 years ago 
At the moment we don't have a Share archetype for the Maven Alfresco SDK 1.0.

Postponing this to 1.0.1

Original comment by colum...@gmail.com on 29 Oct 2012 at 11:48

GoogleCodeExporter commented 8 years ago

Original comment by colum...@gmail.com on 14 Feb 2013 at 10:15

GoogleCodeExporter commented 8 years ago

Original comment by colum...@gmail.com on 13 Jun 2013 at 3:36

GoogleCodeExporter commented 8 years ago

Original comment by colum...@gmail.com on 30 Oct 2013 at 7:07

GoogleCodeExporter commented 8 years ago 
Added an initial Share archetype. 

For now, it just includes an empty share-config-custom.xml and a correct 
file-mappings.properties.

Questions:
 - Should we include an example share-config-custom.xml? Or just an empty one?
 - Should we include (by default) the jars for compiling java code in Share? (I vote yes!)

Original comment by o...@magenta-aps.dk on 16 Jun 2014 at 9:58

GoogleCodeExporter commented 8 years ago 
- Yes, I would say a .sample and will all the possible examples in there
- Absolutely, alfresco-share.jar with scope provided in there

Original comment by colum...@gmail.com on 17 Jun 2014 at 8:00

GoogleCodeExporter commented 8 years ago 
For some reason I never committed the Share archetype, but it's in SVN now.

I've added share-config-custom.xml.sample and the dependencies so we can 
compile java code against Surf and Share. 

Can we look into having the surf in the distribution pom? I'm not a fan of 
having this in the Share pom:
        <dependency>
          <groupId>org.springframework.extensions.surf</groupId>
          <artifactId>spring-surf-api</artifactId>
          <version>1.2.1-M16</version>
          <scope>provided</scope>
        </dependency>

It's a bit hard to figure out exactly which surf version to include.

Original comment by o...@magenta-aps.dk on 22 Jun 2014 at 2:43

GoogleCodeExporter commented 8 years ago 
Thanks Ole,

regarding the spring-surf-api version, we could define it as dependency in the 
<dependencyManagement> of  alfresco-platform-distribution POM file; this you'd 
just need to define groupId and artifactId.

I need to check internally if this is a viable solution.

Original comment by maurizio...@alfresco.com on 3 Jul 2014 at 9:45

GoogleCodeExporter commented 8 years ago 

> regarding the spring-surf-api version, we could define it as dependency in 
the <dependencyManagement> of  alfresco-platform-distribution POM file

This is done for both spring-surf and spring-surf-api, as of 5.0.a.
Check it here: 
https://artifacts.alfresco.com/nexus/service/local/repositories/releases/content
/org/alfresco/alfresco-platform-distribution/5.0.a/alfresco-platform-distributio
n-5.0.a.pom

Original comment by samuel.l...@alfresco.com on 3 Jul 2014 at 9:59