search

DRAGNLabs / 301r_retnet

2 stars 1 forks source link

Update model_args.json name to config.json #16

Closed KimballNJardine closed 4 months ago

KimballNJardine commented 5 months ago

Drew has pointed out that HuggingFace is looking for a config.json file. Our equivalent is named model_args.json. We may want to update the name of the json file output, or create a separate json file called config.json that holds all parameters (maybe not just defaults, but to be determined) to be used for generating a model for inference.

nprisbrey commented 5 months ago

Seems like a good idea. Does the config.json file not allow including any of the values we originally wanted to keep track of?

nprisbrey commented 5 months ago

Is this issue being addressed at all in the hugging_faceify branch @jeffeardley?