search

DRDD2016 / app

0 stars 1 forks source link

Logic for TopBar #302

Closed minaorangina closed 8 years ago

sohilpandya commented 8 years ago

@minaorangina I have fixed this locally, but unable to push online as I created a branch off your resocket branch, and the following test is failing for me. Socket port matches the server port What changes do I need to make to make the test pass?

Thanks

minaorangina commented 8 years ago

@sohilpandya you need to set an environment variable in circleci. PORT=9001

sohilpandya commented 8 years ago

Thanks. had to set that in test-env. 👍

sohilpandya commented 8 years ago

@minaorangina might be worth merging your resocket branch before merging my topbar branch.