Update PlaceholderAPI dependency, and make placeholders persist.

DRE2N / DungeonsXL

Create custom dungeons and adventure maps with ease!

https://www.spigotmc.org/resources/dungeonsxl.9488/

GNU General Public License v3.0

152 stars 84 forks source link

Update PlaceholderAPI dependency, and make placeholders persist. #1061

Closed Maroon28 closed 2 years ago

Maroon28 commented 2 years ago

Previously, if you used /papi reload, the DXL expansion would completely break, as the placeholders didn't persist. This is quite a simple change to fix the issue!

Sataniel98 commented 2 years ago

Why should it use onRequest?

Maroon28 commented 2 years ago

Why should it use onRequest?

If I'm not wrong, onRequest is recommended over onPlaceholderRequest. Here, directly taken from placeholderapi's wiki. If you want to switch it though, feel free to tell me!

Sataniel98 commented 2 years ago

It's fine. I asked because I didn't see what difference it makes and thought I might have missed something. Thank you for the fix.

El Psy Congroo (: