search

DRMF / texvcjs

A LaTeX validator/translator for TeX strings embedded in wikitext
0 stars 2 forks source link

Claude zou master #34

Closed poortho closed 8 years ago

poortho commented 8 years ago

Fix merge conflict for other pull request

physikerwelt commented 8 years ago

please do not reduce the number of tests

physikerwelt commented 8 years ago

I'm discussing with @HowardCohl at the moment. We would like to redistribute the work between @ClaudeZou and @notjagan. Since I expect that it will take a while until the CSV parser is ready. I suggest to split this pull request and merge only the part of the pochhammer replacement. Could you please update this pull request accordingly?

poortho commented 8 years ago

@physikerwelt should I close this?

physikerwelt commented 8 years ago

Yes. I think you need to redo the csv part and use a csv parser from npm.org as discussed. If the library is async. you could promisify (http://bluebirdjs.com/docs/api-reference.html) it.

physikerwelt commented 8 years ago

https://github.com/wikimedia/mathoid/blob/master/scripts/imgUpdate.js#L15 is an example for the fs lib