Closed cfbolz closed 1 month ago
Whoops, sorry, I somehow missed this report.
Yes I think you're quite correct and this logic is straightforwardly wrong. Sorry about that! I'd love a pull request, but if not I'll get around to it at some point soonish.
Hi David!
I'm shrinking input to Z3 that I feed it via a Python script. Z3 ignores
SIGINT
and continues, so when shrinkray tries to kill a process it really needs to useSIGKILL
. However, I'm getting "Could not kill subprocess...", isn't the logic ininterrupt_wait_and_kill
simply wrong?:I think the last if should be
if sp.returncode is None:
, right?I'm happy to open a PR if you tell me whether you also want a test for this situation, or whether you'd be happy simply with the fix.
Apart from that
shrinkray
is working great for my problem!