DRVeyl / RealAntennas

KSP Mod to add better antenna / link calculations to CommNet.
29 stars 22 forks source link

Potential memory leaks identified by KSPCommunityFixes #83

Open Gordon-Dry opened 1 year ago

Gordon-Dry commented 1 year ago

Latest version of KSPCommunityFixes reports on some potential memory leaks on scene changes. A quick look in the log shortly after scene change to Flight Scene shows 3 potential locations in RealAntennas where a leak might exist.

[LOG 20:42:39.415] [KSPCF:MemoryLeaks] A destroyed RealAntennas:RealAntennasUI instance is owning a onGameSceneLoadRequested GameEvents callback. No action has been taken, but unless this mod is relying on this pattern, this is likely a memory leak.
[LOG 20:42:39.416] [KSPCF:MemoryLeaks] Removed a onPlanetariumTargetChange GameEvents callback owned by a destroyed RealAntennas:RACommNetVessel instance
[LOG 20:42:39.416] [KSPCF:MemoryLeaks] Removed a onPlanetariumTargetChange GameEvents callback owned by a destroyed Assembly-CSharp:CommNetVessel instance