DRVeyl / RealAntennas

KSP Mod to add better antenna / link calculations to CommNet.
29 stars 22 forks source link

Small dishes with UHF gain less than 5.0 dBi at TL1 misidentified as omnis after purchasing upgrade #95

Open TwistedGiraffe opened 10 months ago

TwistedGiraffe commented 10 months ago

Reproduction steps:

  1. Start a new save, cheat full tech, and go to RnD. All dishes report correct gains for TL0: screenshot0
  2. Purchase TL1 upgrade. RA misidentifies small dishes with UHF gain less than 5.0 dBi at TL1 as omnis and shows only the TL1 UHF gain. Save-and-load does not restore the misidentification. screenshot3
  3. Purchase TL2 upgrade. RA correctly upgrades the UHF gains to TL2 values and reports them as "omni gains." screenshot6 Note, however, that RA does not upgrade the values if one already right-clicked the part in RnD in the current session before purchasing. For instance, I checked the gain of DR-3 but not the other two before purchasing the TL2 upgrade. DR-3's value remains the TL1 -1.8 dBi but the other two's updated. Save-and-load fixes the issue. This behavior may suggest some caching issues. screenshot9
  4. Finally, purchasing the TL3 upgrade without checking the dishes' gain first restores their identity as dishes. If one right-clicked on those dishes before upgrading, save-and-load fixes the issue. screenshot10