search

DReichLab / AdmixTools

Tools test whether admixture occurred and more
183 stars 64 forks source link

qpDstat not using numchrom from parameter file #78

Closed jooppenh closed 3 years ago

jooppenh commented 3 years ago

Dear Nick,

I think that qpDstat (version 970) does not make use of the numchrom option defined in the parameter file, and so will always default to the global value of 22. It seems to me that numchrom is never set when reading from the par file in qpDstat.c, as it is in eg. qp3Pop.c, though the value in the par file is reported.

Would it be possible to add this option for qpDstat?

Thanks, Jonas

bumblenick commented 3 years ago

You are right! I guess bitrot... will be fixed very soon

N

On Mon, May 31, 2021 at 9:38 PM jooppenh @.***> wrote:

Dear Nick,

I think that qpDstat (version 970) does not make use of the numchrom option defined in the parameter file, and so will always default to the global value of 22. It seems to me that numchrom is never set when reading from the par file in qpDstat.c, as it is in eg. qp3Pop.c.

Would it be possible to add this option for qpDstat?

Thanks, Jonas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DReichLab/AdmixTools/issues/78, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEE77BZCPZO5MGHO2FMLJPTTQQ2ZJANCNFSM453WMO3A .

jooppenh commented 3 years ago

Yes, looks like it was lost in the upgrade to Admixtools v7.0. Thanks!

Best, Jonas