search

DRuggeri / nut_exporter

Network UPS Tools Prometheus Exporter
Other
175 stars 25 forks source link

Feat/add helm chart #45

Open ConnorsApps opened 8 months ago

ConnorsApps commented 8 months ago

This is an update completing some of the original draft MR to add a helm chart.

acolombier commented 8 months ago

Thanks for continuing the work! I think there may have been an issue when rebasing master tho.

I have provided some feedback on your work here and will give this one deeper test/review once @DRuggeri had a chance to give is initial feedback.

ConnorsApps commented 7 months ago

@acolombier I'm using kubeadm with cilium as the CNI and I'm not have problems with an unprivileged, non-host network pod but it might be worth putting a note in the values.yaml with your specific case on why those are necessary in your case.

I've started to look at adding kube rbac proxy, it would be a nice feature if you'd wanna add it but I'm going to be done with this for now.