search

DS-Homebrew / GameYob

[Super] Gameboy [Color] emulator for the Nintendo DS[i]
MIT License
3 stars 0 forks source link

fast-forward to version v0.5.3b-mavica #2

Closed Lana-chan closed 1 year ago

Lana-chan commented 1 year ago

PR as requested by NightScript, feel free to amend the readme after merge

lifehackerhansol commented 1 year ago

this is ultimately at your discretion, but imo version should not exceed 0.5.2 considering upstream has no version higher than this i.e. v0.5.2-mavica1 or something like that would make more sense, at least until it is clear drenn has abandoned work on it (they still seem to be around)

Lana-chan commented 1 year ago

that's a very fair point, though i don't know if i want to backtrack that change in my own repo. i don't plan on making many more features for this (the main thing i wanted to do myself was the pocket camera mapper with DSi cameras), so i think this should be a change made by DS-Homebrew maintainers (which i'm ok being done downstream here, i have no qualms about any of my code being used as long as i'm credited somewhere)

Lana-chan commented 1 year ago

also just as a note the only places where the version is written down are in the readme and changelog files, while the makefile makes it so the version that actually gets written into the binary comes from git describe, so what actually names the version in the emulator itself is the latest git tag

lifehackerhansol commented 1 year ago

Doesn't matter to me either way, just an afterthought lol.