search

DS-Homebrew / TWiLightMenu

DSi Menu replacement for DS/DSi/3DS/2DS
https://wiki.ds-homebrew.com/twilightmenu/
GNU General Public License v3.0
3.29k stars 206 forks source link

Application crashes with DSi Theme if certain skins are selected #1902

Closed ghost closed 2 years ago

ghost commented 2 years ago

Console Configuration: Nintendo DSi using Unlaunch TWiLight Menu++ Version: 24.6.0 TWiLight Menu++ Theme: DSi Theme + Several skins

Expected behaviour

Application boots normally with any selected skins.

Actual behaviour

The application crashes on boot if the Theme setting is set to Nintendo DSi and certain skins are selected.

Steps to reproduce

  1. Open TWiLight Menu++ Settings
  2. Set Theme to Nintendo DSi and select any of the following skins: any of the default skins, including the iQue one, any of the Switch Basic skins
  3. Exit TWiLight Menu++ Settings so the configuration is saved
  4. Crash

Additional Notes: This issue started happening after updating to 24.3.0. At first I thought it was a bad installation and/or SD card corruption. Four updates later I decided to test all the skins after users reported having the same issue on the Discord server, and seeing as the problem persists and only happens with select skins 100% of the time, I think we can cross out a bad installation.

RocketRobz commented 2 years ago

I think this commit caused the issue: bfa60dea

ghost commented 2 years ago

Issue keeps happening in nightly e77e1b28.

Additionally, the 3DS theme presents the same issue with the following skins: Default Light Default Dark Pokémon BW2 - Kyurem Pokémon HGSS - Tower Duo

All the other skins for the 3DS theme work properly. The fallback skins for both DSi and 3DS theme make the app crash as well.

ghost commented 2 years ago

As proven by testing on the Discord server, having the DSi/3DS Theme Music set to Off makes the skins work correctly

ghost commented 2 years ago

I think this commit caused the issue: bfa60de

I don't know if we already crossed this out since it seems to be a problem with the music, but for the record, it happens on the nightly right before that commit was merged. I'm currently rolling back to previous versions to see where the problem begins to appear.

ghost commented 2 years ago

I was rolling back and the problem seems to affect earlier versions too. Weird thing is, these earlier versions had no issues before this bug started presenting on newer versions, so it's like whatever it's happening, it's retroactively breaking older versions. Deleting the cache folder makes the bgm mute when DSi/3DS Theme Music is set to Theme, but also fixes the issue. Additionally, performing a clean install makes the issue dissapear altogether.

spellboundtriangle commented 2 years ago

Does this still occur? Might not be reproducing it correctly but, I tried the iQue skin with the theme music set to Theme (didn't delete any cache), and it seems to work fine. Using a pretty old installation too.

ghost commented 2 years ago

I have the suspicion that this is caused by a combination of using old files and repeatedly switching bethween skins with different custom bgm, since apparently what causes the issue to appear is something wrong with the cache files and having it set to use custom skin bgm.

I have done no testing for this since a clean installation fixed the issue, so I can't be sure if this is something that can happen still, or if whatever that made it happen was fixed already.

lifehackerhansol commented 2 years ago

Closing as we have not heard any reports of this since.

Should anyone continue to encounter this issue, please feel free to reopen or leave a comment.