DS-Homebrew / TWiLightMenu

DSi Menu replacement for DS/DSi/3DS/2DS
https://wiki.ds-homebrew.com/twilightmenu/
GNU General Public License v3.0
3.22k stars 202 forks source link

Save data size issue #2269

Closed KururinX closed 1 year ago

KururinX commented 1 year ago

Flashcard or Exploits? Base Console: NDSi

TWiLight Menu++ Version: 20230809-062923 etc TWiLight Menu++ Theme:

Expected behavior

Save data is generated with the optimal file size by the software

Actual behavior

Save data is generated at 512KB

Notes

Since the August release of Twilight Menu, the size of the automatically generated .sav files has changed. If it is an existing .sav it will be fixed.

20230729-055906...64KB(Sekaiju no MeiQ 1sav.9) 20230809-062923…512KB (Sekaiju no MeiQ 1.sav8)

As far as I have verified, other software was similarly generated at 512 KB. クリップボード一時ファイル01

Peter0x44 commented 1 year ago

I don't think this is a bug, just a strategy Allocating more storage than needed spares needing a whole lookup table of tids and corresponding sizes like melonds, and also doesn't really have a big downside

Peter0x44 commented 1 year ago

https://github.com/melonDS-emu/melonDS/blob/master/src/ROMList.cpp The code in melonDS I'm talking about

Peter0x44 commented 1 year ago

Nevermind, I didn't read that properly It was creating correctly sized saves before?