The conditions for playing the startup jingle are now more closely tied to the music setting rather than just using the 3DS theme.
The jingle plays when Regular (3DS) music is set and does not play when Regular (DSi) music is set, regardless of theme. (Saturn is still mute)
When the music is set to Theme the jingle will only play if enabled via theme.ini (#2071 is also fixed)
The built-in 3DS theme now enables the jingle in its config (partially addresses #2055)
HBL theme now plays the HBL music when music is set to Theme (it previously used DSi music in this case)
Where have you tested it?
melonDS 0.9.5
Pull Request status
[x] This PR has been tested using the latest version of devkitARM and libnds.
Other notes
I almost added behavior to set PlayStartupJingle = 1 to be the default when unspecified in 3DS skins, but decided against it for two reasons. It would be a breaking change to pretty much every 3DS skin that uses custom music as most don't specify PlayStartupJingle, and this behavior would be removed anyway if a merger of all DSi-based skins is to happen eventually.
In order to fully close #2055 that RVID file would have to be added to NitroFS, though that would obviously increase the binary size and I don't know if y'all want to do that so I'm just going to leave that alone lol
What's changed?
The conditions for playing the startup jingle are now more closely tied to the music setting rather than just using the 3DS theme.
Regular (3DS)music is set and does not play whenRegular (DSi)music is set, regardless of theme. (Saturn is still mute)Themethe jingle will only play if enabled viatheme.ini(#2071 is also fixed)Theme(it previously used DSi music in this case)Where have you tested it?
melonDS 0.9.5
Pull Request status
Other notes
PlayStartupJingle = 1to be the default when unspecified in 3DS skins, but decided against it for two reasons. It would be a breaking change to pretty much every 3DS skin that uses custom music as most don't specifyPlayStartupJingle, and this behavior would be removed anyway if a merger of all DSi-based skins is to happen eventually.