DS-Homebrew / TWiLightMenu

DSi Menu replacement for DS/DSi/3DS/2DS
https://wiki.ds-homebrew.com/twilightmenu/
GNU General Public License v3.0
3.15k stars 197 forks source link

DSi-Based themes: Fix broken game detection when sorting by recent #2433

Closed mentusfentus closed 2 weeks ago

mentusfentus commented 2 weeks ago

What's changed?

Fixes #2432: In my previous pull request, I made an oversight that broke game detection when sorting by recently played. This caused the game to launch with incorrect information, such as the wrong game type, region, or AP-patch.

This happened because the app launching code depended on the CURPOS variable, and my code modified its value right before the game launched. This led to TWLmenu failing to detect the game properly.

To fix this, the app launching code now uses the variable cursorPosOnScreen instead of CURPOS. This name matches the one used in _romselakmenu for consistency.

Where have you tested it?

Pull Request status