search

DS-Homebrew / twlmenu-extras

This is the repository where extra files for TWiLight Menu++ are hosted
https://skins.ds-homebrew.com
122 stars 53 forks source link

[Security] Workflow update.yml is using vulnerable action actions/checkout #33

Closed Freakston closed 2 years ago

Freakston commented 2 years ago

The workflow update.yml is referencing action actions/checkout using references v1. However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability. The vulnerability fix that is missing by actions version could be related to: (1) CVE fix (2) upgrade of vulnerable dependency (3) fix to secret leak and others. Please consider to update the reference to the action.

Epicpkmn11 commented 2 years ago

We can't use actions/checkout@2 since devkitPro's docker image is too outdated

lifehackerhansol commented 2 years ago

It seems to work fine: https://github.com/lifehackerhansol/twlmenu-extras

Epicpkmn11 commented 2 years ago

That one doesn't have submodules, submodules are the issue

Epicpkmn11 commented 2 years ago

Oh I missed which repo this one on, so I guess it's fine here but all of the other repos that use devkitPro's docker and submodules this is an issue for