DS4PS / cpp-527-fall-2020

http://ds4ps.org/cpp-527-fall-2020/
0 stars 1 forks source link

Lab 05 table demo pic was there...and now it's not #38

Open krbrick opened 3 years ago

krbrick commented 3 years ago

my files and folders are all linked appropriately and in the right place...yesterday this pic was visible and now it is gone. Yesterday evening I at least had a blue question mark for a bad file, but now there is nothing. Any advice? https://krbrick.github.io/lab05.io/table-demo/ https://github.com/krbrick/lab05.io/blob/master/table-demo.md

---
layout: liquid-table
title: 'amiright?'
reynolds:
  strengths:
  - good father
  - funny
  - dated alanis morissette
  weaknesses: 
  - singing
  - green lantern movie
  - tennis backhand 
gosling:
  strengths: 
  - builds houses
  - is a real boy
  - never dated alanis morissette
  weaknesses: 
  - micky mouse club
  - cries a lot
  - not ryan reynolds
---

![]({{site.url}}/assets/img/gallery-1481570039-gettyimages-629207774.jpg)

![]({{site.url}}/assets/img/ryan-v-ryan.jpg)  

## Lorem Ipsum

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. 
Niagara1000 commented 3 years ago

try getting rid of this part:

![]({{site.url}}/assets/img/gallery-1481570039-gettyimages-629207774.jpg)

that worked for me

krbrick commented 3 years ago

try getting rid of this part:

![]({{site.url}}/assets/img/gallery-1481570039-gettyimages-629207774.jpg)

that worked for me

yes, that is a different image I tried to code into the website using the same steps to see if it would work. I have removed that line but still no luck. Thanks tho!

imanprs commented 3 years ago

I would double check the url set for _config.yml. It seems that the address you are referring to here leads to no image. The {site.url} parameter takes the url that you set for the yml configuration. I believe that it should work if that address is krbrick.github.io/lab05.io/ because in this case the full address is (https://krbrick.github.io/lab05.io/assets/img/ryan-v-ryan.jpg) which does show your image.

imanprs commented 3 years ago

As I was playing around to see what could be the issue, I encountered something. You may have deleted and uploaded the file with the same name again. For me it wouldn't bring back the image until I made additional changes to the page. Probably something to do with Github md processing or something like that. So you can try doing that, making some changes like adding a line of text to the page, committing, then check to see if the image is back. If it is, undo the changes and it should be fine. Another way is to upload the image with a different name and change the name on the page too.

Niagara1000 commented 3 years ago

As I was playing around to see what could be the issue, I encountered something. You may have deleted and uploaded the file with the same name again. For me it wouldn't bring back the image until I made additional changes to the page. Probably something to do with Github md processing or something like that. So you can try doing that, making some changes like adding a line of text to the page, committing, then check to see if the image is back. If it is, undo the changes and it should be fine. Another way is to upload the image with a different name and change the name on the page too.

Is there a way to undo changes made on GitHub once you commit the file? I always had to manually compare the before and after versions and finally bring the document back to the original state

lecy commented 3 years ago

@krbrick I believe @imanprs is correct.

The {{site.url}} variable would be replaced with whatever variable called url you have defined in the site file, the _config.yml file.

So in that file you would need to add:

url: https://krbrick.github.io/lab05.io

As noted when the {{site.url}} variable is replaced you will have the full path to your image.

krbrick commented 3 years ago

thank you @imanprs @lecy ! I added to the config file:

url: https://krbrick.github.io/lab05.io

under

avatar: "/assets/img/avatar-icon.png"

and it worked immediately.

krbrick commented 3 years ago

As I was playing around to see what could be the issue, I encountered something. You may have deleted and uploaded the file with the same name again. For me it wouldn't bring back the image until I made additional changes to the page. Probably something to do with Github md processing or something like that. So you can try doing that, making some changes like adding a line of text to the page, committing, then check to see if the image is back. If it is, undo the changes and it should be fine. Another way is to upload the image with a different name and change the name on the page too.

I did delete the file and upload it again, with a new name, same name, etc. It makes sense that it was more of a root issue (ie config file) because nothing was working from the other way. Thanks for looking into it so thoroughly. You've really got a head for it.