DSACMS / dedupliFHIR

Prototype for basic deduplication and aggregation of eCQM data
Creative Commons Zero v1.0 Universal
8 stars 3 forks source link

Frontend: Minor UI Fixes #156

Closed natalialuzuriaga closed 2 months ago

natalialuzuriaga commented 2 months ago

Frontend: Minor UI Fixes

Problem

Made a couple of minor UI fixes based on Meg's feedback on #131 https://github.com/DSACMS/dedupliFHIR/pull/131#issuecomment-2358904019

Solution

Result

index.html:

Screenshot 2024-09-18 at 12 25 50 PM

success.html:

Screenshot 2024-09-18 at 12 25 35 PM

Test Plan

npm test to run frontend tests

mpeterz commented 2 months ago

Looks good! The only thing I'd do is add a line space where you see the red X's here. This will prevent the UI elements from running together. I'm also inclined to add "your" so it's "your results data". TY!

DD-home-screen
mpeterz commented 2 months ago

Requested minor updates: line spacing and inserting 1 word.

natalialuzuriaga commented 2 months ago

Done! Will merge this PR in so we can have the build ready for tomorrow's beta session

Screenshot 2024-09-18 at 5 50 59 PM