DSACMS / dedupliFHIR

Prototype for basic deduplication and aggregation of eCQM data
Creative Commons Zero v1.0 Universal
8 stars 1 forks source link

FHIR Parser should accommodate elements with multiple cardinality. #54

Open cooperthompson opened 5 months ago

cooperthompson commented 5 months ago

Describe the bug For many demographics, it is possible for a single patient to have multiple values for that demographic.

For example, a person may have multiple addresses. The address list may include both current and past addresses, as well as temporary addresses (e.g., hotel), or the patient may just live intermittently at different locations (for example, a child whose parents split custody). Similarly with telecom information (both phone numbers, and e-mail addresses).

Also, in FHIR, the middle name is usually represented as second repetition of the given name component, so in order or middle name to be used as an input or matching, all repetitions of the given name should be accounted for.

To Reproduce I didn't reproduce this - rather, I'm reporting this based on code review of the read_fhir_data method.

Expected behavior Patient de-duplication should handle patients that have multiple values for:

While I am reporting this for the FHIR parser, QRDA will usually allow for similar data repetitions to FHIR.

Actual behavior It appears like the FHIR parser only grabs the first repetition of several elements.

IsaacMilarky commented 4 months ago

This is a good feature to add in the future. It seems very feasible from the expected behavior. I will work on this and update when a PR is ready.