search

DSACMS / metrics

Experimentations in Open Source Repository Metrics
https://dsacms.github.io/metrics/
Other
6 stars 3 forks source link

GH Actions: Added frontend-checks job #100

Closed natalialuzuriaga closed 6 months ago

natalialuzuriaga commented 6 months ago

GH Actions: Added frontend-checks job

Problem

Linting and code styling checks were missing from our PR review jobs.

Solution

checks.yml now includes checks for linting and code styling by running the commands:

IsaacMilarky commented 6 months ago

Seems almost golden. Eslint seems to not be installing properly because of a path issue however:

 Running `npm install` to install eslint ...
  npm ERR! code ENOENT
  npm ERR! syscall open
  npm ERR! path /home/runner/work/metrics/metrics/package.json
  npm ERR! errno -2
  npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/metrics/metrics/package.json'
  npm ERR! enoent This is related to npm not being able to find a file.
  npm ERR! enoent 

  npm ERR! A complete log of this run can be found in:
  npm ERR!     /home/runner/.npm/_logs/2024-04-05T16_36_25_534Z-debug-0.log

It looks like it should work with some tweaks of the working directory @natalialuzuriaga