There is a missing set of parenthesis in the boolean logic in reports generation to determine whether a number is highlighted green or red. This was causing unintended behavior.
Below is an example of the unintended evaluation:
The problem is hard to spot at first; because of a missing set of parenthesis the inequality operator != was evaluating the numeral 0 instead of raw_diff > 0.
Solution
Add extra sets of parenthesis to this section of gen_reports.py.
Result
This will result in the desired colors being used to highlight report diffs.
Fix Error in Report Generation
Problem
There is a missing set of parenthesis in the boolean logic in reports generation to determine whether a number is highlighted green or red. This was causing unintended behavior.
Below is an example of the unintended evaluation:
The problem is hard to spot at first; because of a missing set of parenthesis the inequality operator
!=was evaluating the numeral0instead ofraw_diff > 0.Solution
Add extra sets of parenthesis to this section of
gen_reports.py.Result
This will result in the desired colors being used to highlight report diffs.