DSC-McMaster-U / Gamified-Learning-Platform

MIT License
6 stars 14 forks source link

Modified Lesson Page to Render Course Info Dynamically #121

Closed MithunPara closed 7 months ago

MithunPara commented 8 months ago

Changes Made:

Future Changes/Things to Note:

MithunPara commented 8 months ago

Primary reviewer: @alexchen2

alexchen2 commented 8 months ago

On an unrelated topic, do you mind making a small change within the lesson.css file at line 193-194 (.tabs-unit-menu), replacing the border-right and border-bottom properties with this:

    ...
    filter: 
        drop-shadow(1.5px 0px 0px #c3c3c3)
        drop-shadow(0px 1px 0px #c3c3c3);
    ...

I noticed when looking over the placeholder tabs that with those border properties, the entire menu creates this ugly hanging line like this, if the bottom module tab is open:

image

I think stuff like borders and box-shadow use some sort of CSS "box model", which causes them to render in the element's rectangular area and disregard any sort of custom shapes. Using a filter drop shadow to emulate these borders should allow for wrapping around the submenu tabs, getting rid of that overextended line:

image

Sorry for asking you to do this—I just didn't want to create another separate PR and bother others with reviewing it, just to make such a small change.