Open ttimbers opened 3 months ago
Project Strengths
Areas of Improvement
src
only some scripts have numeric prefixes, in tests
only some scripts have test_
prefix)filter-raw-data.py
has definition for functions read()
and filter_columns()
, but the read.py
and filter_columns.py
scripts also define functions read()
and filter_columns
. filter-raw-data.py
does not import functions from either of the other scripts.)requirements.txt
is empty file in root directorydata/processed
) and scripts do not read data from web URLmake all
doesn't work because there are no raw data files to accessdocker build -t airline-project
returned the following error:
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.
Usage: docker buildx build [OPTIONS] PATH | URL | -
Start a build
I think the proper build command is just missing a dot:
docker build -t airline-project .
- Building and running Docker container does not install required packages (still have to create env from yml file). I think this is because `requirements.txt` is empty
- `LICENSE` does not have team/team members as authors (DSCI 310 attributed instead)
- Perhaps could add clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support
#### Attribution
This was derived from the [JOSE review checklist](https://openjournals.readthedocs.io/en/jose/review_checklist.html) and the ROpenSci review checklist.
Strengths:
Improvements:
This was derived from the JOSE review checklist and the ROpenSci review checklist.
2
scripts
directory and the functions should be in src
.README.md
doesn't work - invokes an argument error. It's missing a period (".") at the end. It's also a good idea to work with a docker-compose
file instead - makes the starting and closing of containers easier.Dockerfile
is very unlike the way we've learnt to build it in class.requirements.txt
is empty.make all
command does not work:
The Makefile
is missing the commands to load the above data files. The raw data can't be found in general (the link or the csv file) so essential to make that fix.03_test_split_data.py
- there is no import for sys even though it's being used.Figure 6
on the report is a bit unclear - can't tell what it's trying to convey.CONTRIBUTING
should be more detailed - refer to an example repo from the assignment or another group's file to see what the file should look like.This was derived from the JOSE review checklist and the ROpenSci review checklist.
30 mins
Please provide more detailed feedback here on what was done particularly well, and what could be improved. It is especially important to elaborate on items that you were not able to check off in the list above.
This was derived from the JOSE review checklist and the ROpenSci review checklist.
Submitting authors: Siddharth Balodi, Charles Benkard, Mikel Ibarra Gallardo, and Stephanie Ta
Repository: https://github.com/DSCI-310-2024/dsci-310_airline-delay-classification_group-17/releases
Abstract/executive summary:
In this project, we delve into a 2019 airline delays dataset to dissect the intricate factors contributing to flight disruptions. Our analysis aims to address pivotal questions, such as what are the primary drivers behind flight delays and cancellations? Are certain airlines or airports more vulnerable to these disruptions? How do external factors like adverse weather conditions or air traffic congestion exacerbate flight schedules? While previous studies have touched upon aspects of flight disruptions, we endeavor to provide a deeper understanding through the lens of analytical techniques, including descriptive statistics, data visualization, and machine learning algorithms (specifically KNN classification).
Through our exploration, we have unearthed compelling insights. We have found that airport congestion, inclement weather, and airline operational issues are key contributors to flight disruptions. Furthermore, our analysis has revealed disparities in performance among airlines and airports, shedding light on areas ripe for operational enhancements and service improvements. By leveraging these findings, stakeholders within the aviation industry can make informed decisions aimed at minimizing disruptions and enhancing overall operational efficiency.
The significance of our research extends beyond the realm of academia. By unraveling the complexities of flight disruptions, we aim to empower decision-makers with actionable insights to navigate the challenges inherent in air travel. Moreover, our findings hold the potential to drive positive change within the aviation industry, ultimately leading to a more seamless and reliable travel experience for passengers worldwide.
Editor: @ttimbers
Reviewer: Yanxin Liang, Rashi Selarka, Caden Chan, Zackarya Hamza