DSD-DBS / capella-collab-manager

A web app for collaboration on Capella (MBSE) projects
https://dsd-dbs.github.io/capella-collab-manager/
Apache License 2.0
20 stars 3 forks source link

fix: Infinite authentication loop #1622

Closed MoritzWeber0 closed 2 months ago

MoritzWeber0 commented 2 months ago

When the refresh token was expired, the backend sent the error "TOKEN_SIGNATURE_EXPIRED". The frontend did then request a new refresh token, leading to an infinite loop and a DDOS attack on our backend.

The error was accidentially added in #1569.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (27e5007) to head (a1a0314).

Files Patch % Lines
...nd/capellacollab/core/authentication/basic_auth.py 0.00% 1 Missing :warning:
...acollab/core/authentication/provider/oauth/flow.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1622 +/- ## ========================================== + Coverage 80.64% 80.66% +0.01% ========================================== Files 185 185 Lines 6029 6035 +6 Branches 675 675 ========================================== + Hits 4862 4868 +6 Misses 1021 1021 Partials 146 146 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud