DSD-DBS / capella-collab-manager

A web app for collaboration on Capella (MBSE) projects
https://dsd-dbs.github.io/capella-collab-manager/
Apache License 2.0
23 stars 4 forks source link

Make deploy fails on macOS #465

Closed mPorhel closed 1 year ago

mPorhel commented 1 year ago

Hello,

I tried to deploy the fresh v2.1.0 yesterday evening on macOS Ventura 13.1 (intel), GNU Make 3.81. (fresh clone, submodules on the expected commit, correct file permissions)

I got errors the following error at deploy/deploy-t4c steps (with versions set to 5.2.0 or 5.2.0/6.0.0):

for version in 5.2.0
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [capella] Error 2
for version in 5.2.0 6.0.0
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [t4c-client] Error 2

Fast try to avoid the error seems to work by removing the loop and the call to $(CAPELLA_DOCKERIMAGES) :

capella:
    $(MAKE) -C capella-dockerimages PUSH_IMAGES=1 DOCKER_REGISTRY=$(LOCAL_REGISTRY_NAME):$(REGISTRY_PORT) CAPELLA_VERSION=5.2.0 capella/remote capella/readonly
    $(MAKE) -C capella-dockerimages PUSH_IMAGES=1 DOCKER_REGISTRY=$(LOCAL_REGISTRY_NAME):$(REGISTRY_PORT) CAPELLA_VERSION=6.0.0 capella/remote capella/readonly

t4c-client:
    $(MAKE) -C capella-dockerimages PUSH_IMAGES=1 DOCKER_REGISTRY=$(LOCAL_REGISTRY_NAME):$(REGISTRY_PORT) CAPELLA_VERSION=5.2.0 t4c/client/remote t4c/client/backup
    $(MAKE) -C capella-dockerimages PUSH_IMAGES=1 DOCKER_REGISTRY=$(LOCAL_REGISTRY_NAME):$(REGISTRY_PORT) CAPELLA_VERSION=6.0.0 t4c/client/remote t4c/client/backup
MoritzWeber0 commented 1 year ago

Hi @mPorhel. Thanks for reporting the issue! As you mentioned, the .ONESHELL option has been introduced in version 3.82 of Make. macOS ships with 3.81 per default (which is a version from 2006). I've added the minimum version to the README in the referenced commit.

mPorhel commented 1 year ago

With GNU Make 4.4 (installed with brew install make and then deployed to replace with 4.4 by adding export PATH="/usr/local/opt/make/libexec/gnubin:$PATH" in .zshrc

The loop issue is solved


make[2]: Entering directory 'xxx'
...
make[2]: Leaving directory 'xxx'
``
`

I might open further issues regarding the status of my next trials.

Regards