DSD-DBS / capellambse-context-diagrams

Extension for python-capella-mbse that adds automatically generated context diagrams for arbitrary model elements.
https://dsd-dbs.github.io/capellambse-context-diagrams/
Other
13 stars 0 forks source link

Refactor Dataflow View #102

Closed huyenngn closed 4 months ago

huyenngn commented 5 months ago

Closes #70

Wuestengecko commented 5 months ago

There's a bit of overlap between your 3 PRs.

First, there's some confusion about what belongs to refactor-default (#99) and fix-physical-components (#100):

* cbc038b (origin/refactor-default) refactor: Shorter collector function
| * 90099cc (origin/fix-physical-components) feat: Add Physical Links for Context Diagrams
| * 7972e0b test: Add test case
| *   8a1111b merge: Merge better code PR
| |\
| |/
|/|
* | ee52fd4 refactor: Code improvements
| * 01ca54b test: Add test data
|/
* 8634a24 (tag: v0.2.36) Add-owners (#98)

Then there's also ee52fd4 - in both #99 and #100, see above - and 1936ce9 - in here -, which are both described as "refactor: Code improvements", but are vastly different from each other:

--- ee52fd4f8daf719437b1b3d8a8a6d429a8c35e51
+++ 1936ce92930c190f48c0c2c131b7a62d43cb6520
@@ -1,9 +1,8 @@
-commit ee52fd4f8daf719437b1b3d8a8a6d429a8c35e51
+commit 1936ce92930c190f48c0c2c131b7a62d43cb6520
 Author: huyenngn <ngan-huyen.thi-nguyen@deutschebahn.com>
-Date:   Wed May 15 16:41:26 2024 +0200
+Date:   Tue May 28 11:53:52 2024 +0200

-    refactor: Code improvements
+    refactor: Code Improvements

- capellambse_context_diagrams/collectors/default.py | 39 +++++++++-------------
- capellambse_context_diagrams/context.py            | 20 +++++------
- 2 files changed, 23 insertions(+), 36 deletions(-)
+ .../collectors/dataflow_view.py                    | 127 ++++++++-------------
+ 1 file changed, 45 insertions(+), 82 deletions(-)

The second part is probably gonna be fine if things just get squashed together as usual, but the first part might be worth addressing regardless, just to decouple the two PRs (if that even makes sense).