Set runtime of lambdas associated with API Gateway Endpoints to Node js v18 - Githubissues

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code

MIT License

26 stars 8 forks source link

Set runtime of lambdas associated with API Gateway Endpoints to Node js v18 #1025

Closed karkir0003 closed 1 year ago

karkir0003 commented 1 year ago

Problem AWS has been sending emails to DLP saying that the node runtime of the API Gateway Lambda endpoints were running on Node 14 and that we are recommended to use Node js v18 as the runtime.

Solution For the Api construct in SST (under AppStack.ts, set the runtime prop for the lambda (under default: {functions: {...}}) to be "nodejs18.x". View these links from SST for more detail:

https://docs.sst.dev/constructs/Api - configure Function property within the Api construct
https://docs.sst.dev/constructs/Function#runtime - function runtime property

Testing Methodology

cd serverless && yarn sst dev - deploy api to dev stack (set resource name as dev) and then see if the nodejs runtime is version 18
Make sure to run an SST prod deploy when ready right about when you merge PR

Other considerations

Github action to automatically do sst deploy
Github action to validate if the AppStack.ts is configured correctly
dev vs. prod stack best practice (@dwu359 can you comment here)