DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code

MIT License

24 stars 8 forks source link

Pnpm #1044

Closed dwu359 closed 11 months ago

dwu359 commented 11 months ago

pnpm

What solution does this PR provide?

Switches package management from yarn to pnpm for frontend and serverless.

Also modified the dlp-cli so that it uses pnpm instead of yarn. Also add a --yarn flag in case if anyone is in the process of transitioning from yarn to pnpm.

Also modified node build check workflow to use pnpm instead of yarn.

Testing Methodology Everything was able to be installed via pnpm.

Any other considerations https://github.com/DSGT-DLP/dlp-cli/pull/11

sweep-ai[bot] commented 11 months ago

Apply Sweep Rules to your PR?

[ ] Apply: Leftover TODOs in the code should be handled.
[ ] Apply: All new business logic should have corresponding unit tests in the tests/ directory.
[ ] Apply: Any clearly inefficient or repeated code should be optimized or refactored.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

karkir0003 commented 11 months ago

@dwu359 can you add an explanation in the github issue (or pr) for why we want to use pnpm over yarn? have we ensured that pnpm can still install any node dependency we want to use in the future (at least for 90+% of our potential usecases).

dwu359 commented 11 months ago

@dwu359 can you add an explanation in the github issue (or pr) for why we want to use pnpm over yarn? have we ensured that pnpm can still install any node dependency we want to use in the future (at least for 90+% of our potential usecases).

From what I've read, pnpm is slightly faster than yarn berry and uses up less space than yarn because it utilizes symlinks instead of directly copying packages. That did seem the case for my machine, but I'll need other ppl to try it out also if that is the case. Pnpm was able to install basically anything that I threw at it, since it installs from the npm registry.

dwu359 commented 11 months ago

Actually if you look at the build times for https://github.com/DSGT-DLP/Deep-Learning-Playground/actions/workflows/node.js.yml, it does seem to be about 20s faster

farisdurrani commented 11 months ago

Works on my laptop

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication