DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code
MIT License
24 stars 8 forks source link

React Build + Directory Tree Workflow Fixes #1049

Closed farisdurrani closed 10 months ago

farisdurrani commented 10 months ago

React Build + Directory Tree Workflow Fixes

Github Issue Number Here: N/A What user problem are we solving?

  1. Generate directory tree workflow is failing
  2. /serverless does not have an ESLint checker
  3. /frontend's lint was not configured to run automatically in the build check
  4. Multiple /frontend lint errors

What solution does this PR provide?

  1. Upgraded the auto-commit github action from v4 -> v5, fixing generate-directory-tree workflow
  2. Implemented an ESLint checker for /serverless, can run using yarn lint in /serverless
  3. Added pnpm lint to the build check for /frontend. TODO: Add yarn lint to build check for /serverless
  4. Fixed /frontend lint errors, mostly unused vars

Testing Methodology

How did you test your changes and verify that existing functionality is not broken

  1. Did yarn lint in /serverless, pnpm lint in /frontend
  2. Did pnpm start in /frontend

No issues reported after running these tests

Any other considerations N/A

sweep-ai[bot] commented 10 months ago

Apply Sweep Rules to your PR?

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication