DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code

MIT License

24 stars 8 forks source link

Login Page Refactor #1054

Closed alantao912 closed 10 months ago

alantao912 commented 10 months ago

Login Page Refactor

What user problem are we solving?

Linked to #1055

Distinctive first name and last name input boxes
Validates name inputs
Password confirmation box

What solution does this PR provide?

Allows user to input first and last name separately
Checks if first and last names only contains characters
Forces user to type in password identically twice to prevent misinput

Testing Methodology

Clicked through registration page several times Functionality is not broken

Any other considerations

sweep-ai[bot] commented 10 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

karkir0003 commented 10 months ago

@alantao912 can you attach a screen recording that walks through the various edge cases

karkir0003 commented 10 months ago

Login Page Refactor

What user problem are we solving?

Distinctive first name and last name input boxes

Validates name inputs

Password confirmation box

What solution does this PR provide?

Allows user to input first and last name separately

Checks if first and last names only contains characters

Forces user to type in password identically twice to prevent misinput

Testing Methodology

Clicked through registration page several times Functionality is not broken

Any other considerations

can you create a github issue and link it to the PR description so that we can track the work

alantao912 commented 10 months ago

@karkir0003 Demo video https://github.com/DSGT-DLP/Deep-Learning-Playground/assets/70001632/4917d351-7ec8-47fe-b7b6-a4dcc43083bc

karkir0003 commented 10 months ago

@karkir0003 Demo video https://github.com/DSGT-DLP/Deep-Learning-Playground/assets/70001632/4917d351-7ec8-47fe-b7b6-a4dcc43083bc

Very good!!!

Couple questions mainly on toast errors:

if I enter a first name or last name like "123" and it's invalid, we should make the toast message say something like "invalid first name/last name. please enter only letters"
for the error message about "firebase auth error: user in use, we should make this message a bit cleaner on the UI side"

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication