depcheck action workflow

DSGT-DLP / Deep-Learning-Playground

Web Application where people new to Deep Learning can input a dataset and toy around with basic Pytorch modules without writing any code

MIT License

26 stars 8 forks source link

depcheck action workflow #1067

Closed prishavall closed 10 months ago

prishavall commented 11 months ago

Github Issue: #869

We have instances where we install a frontend library with yarn, but then we don't actually end up using it in our code. We should try to keep our frontend package size as small as possible and keep only the essentials to make our builds run faster

It provides a new command npx dep-check to see if there are any unused dependencies

Testing Methodology Ran it through the front-end directory

sweep-ai[bot] commented 11 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

karkir0003 commented 11 months ago

@farisdurrani are the package.json files correctly updated? @prishavall needed to add depcheck as a dev dependency?

farisdurrani commented 11 months ago

Yes, it's more apt to put in devDep since it's not a critical functionality for the app

sonarcloud[bot] commented 10 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

farisdurrani commented 10 months ago

Lgtm